Refactor search #1594
Refactor search #1594
Conversation
| }) | ||
| .then((results) => | ||
| results.map((result) => ({ | ||
| id: `${result.type}-${result.match.id}`, |
There was a problem hiding this comment.
aaah this is so much nicer than the solution I came up with in my useMemberships hook yesterday.. (i added ids in the store action)
| import { SearchResult } from './components/types'; | ||
| import { remoteList, RemoteList } from 'utils/storeUtils'; | ||
|
|
||
| export type SearchResultItem = { |
There was a problem hiding this comment.
yep i should have done like this as well....
| @@ -17,17 +17,28 @@ export function loadListIfNecessary< | |||
| remoteList: RemoteList<DataType> | undefined, | |||
| dispatch: AppDispatch, | |||
| hooks: { | |||
| actionOnError?: (err: unknown) => PayloadAction<unknown>; | |||
There was a problem hiding this comment.
ooo smart addition! I can see this coming in handy! :D
| resultsError: (state, action: PayloadAction<[string, unknown]>) => { | ||
| const [query, error] = action.payload; | ||
| state.matchesByQuery[query] = remoteList(); | ||
| state.matchesByQuery[query].error = error; |
There was a problem hiding this comment.
nice! I have not seen the error part of these in action anywhere else i think, seems like something we want to take into more parts!
There was a problem hiding this comment.
True! I just delayed error handling (lazily) but there was a test here that failed, and I had to decide whether to rip out the test and all the error code, or just implement crude error handling, so I chose the latter. 😊
richardolsson
merged commit b269623
into
issue-1542/refactor-to-use-hooks
Description
This PR refactors the search feature to use redux instead of react-query.
Screenshots
None
Changes
searchfeatureuseSearch()hookuseSearch()inSearchDialogNotes to reviewer
None
Related issues
Related to #1542